feat(cmd): restore plugin skill auto-install; fix undefined tryInstallPluginSkills CI failure#16
Closed
Copilot wants to merge 2 commits into
Closed
feat(cmd): restore plugin skill auto-install; fix undefined tryInstallPluginSkills CI failure#16Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
- Add cmd/plugin_skills.go with tryInstallPluginSkills(name string) that looks up clime-<name> on PATH, runs `skills` subcommand, fetches the returned repo manifest, and installs any skills not already present - Add pluginSkillInstaller var in cmd/plugin.go and invoke it from executePluginInstall after successful manifest save - Fixes undefined: tryInstallPluginSkills CI failure in go vet Agent-Logs-Url: https://github.com/git-hulk/clime/sessions/3680a0d7-99ec-46e5-a4bb-39916baa418a Co-authored-by: git-hulk <4987594+git-hulk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add implementation for tryInstallPluginSkills function
feat(cmd): restore plugin skill auto-install; fix undefined tryInstallPluginSkills CI failure
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go vet ./...was failing becausecmd/plugin_skills_test.goreferencedtryInstallPluginSkillsandpluginSkillInstallerthat no longer existed in the codebase.Changes
cmd/plugin_skills.go(new): implementstryInstallPluginSkills(name string)— a best-effort, silent-failure hook that:clime-<name>on PATH<binary> skillsto get a skill sourcecmd/plugin.go: addspluginSkillInstaller = tryInstallPluginSkillsto the package-level vars and wires the call intoexecutePluginInstallafter a successful plugin install + manifest save:Original prompt
The CI job failed in repository
git-hulk/climebecausego vet ./...reportsundefined: tryInstallPluginSkillsincmd/plugin_skills_test.go.Relevant context:
.github/workflows/ci.yaml4bb95ace6f4a53e761f1668d5a71c1a89b928834cmd/plugin_skills_test.gocmd/plugin.gowas already updated on branchfix-plugin-skills-cito restore the plugin skill installer hook and invokepluginSkillInstaller(name)after successful plugin installation.cmd/plugin_skills.goand then create a pull request.Please complete the fix by:
cmd/plugin_skills.gowith a best-effort implementation oftryInstallPluginSkills(name string)that:clime-<name>on PATH<plugin-binary> skillsinstallSkillEntry(...)fix-plugin-skills-ciintomaster.Use the existing changes already present on branch
fix-plugin-skills-cias the starting point. Create a concise PR title and description explaining that this restores plugin skill auto-install support and fixes the CI failure caused by the missingtryInstallPluginSkillssymbol.The following is the prior conversation context from the user's chat exploration (may be truncated):
User: Please find a solution for this failing job. Use the logs, job definition, and any referenced files where the failure occurred. Keep your response focused on the solution and include code suggestions when appropriate.
Assistant: The failure is a compile/vet error caused by a test referencing a function that no longer exists:
cmd/plugin_skills_test.goundefined: tryInstallPluginSkillsgo vet ./...Solution
Restore the missing
tryInstallPluginSkillssymbol or update the tests to match the renamed implementation. Since the tests consistently calltryInstallPluginSkills(...), the lowest-risk fix is to reintroduce that function and keep it wired to the current plugin skill installer flow.A simple compatibility fix is:
If the implementation was renamed, add a wrapper instead of duplicating logic:
Why this is the right fix
The test file expects all of this behavior from
tryInstallPluginSkills:skillssubcommand failsThose expectations are encoded throughout
cmd/plugin_skills_test.go. The build is failing before tests even run, so the immediate issue is just the missing function symbol.Recommended code shape
If you want to preserve testability and the existing injection point used later in the file, this pattern is appropriate:
If the code was intentionally renamed
Then update the tests instead, replacing:
with the new function name everywhere in
cmd/plugin_skills_test.go.But unless there was a deliberate API cleanup, restoring
tryInstallPluginSkillsis the better fix because:pluginSkillInstallerMinimal actionable fix
Add back this functi...
This pull request was created from Copilot chat.